Skip to content

Explicitly include NULL as a value that tagQueryFindDescendants_() shouldn't traverse #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Explicitly include NULL as a value that tagQueryFindDescendants_() shouldn't traverse #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3ef516
Close #407. Explictly include NULL as a value that tagQueryFindDescen…
cpsievert Oct 2, 2023
dc29118
Update news
cpsievert Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

* `css()` now fully supports setting custom CSS properties (or CSS variables) via inline styles. When the name of a value passed to `css()` starts with `--`, it will be treated as a custom CSS property and absolutely no changes will be made to the variable. For example, `css("--font_size" = "3em")` returns `--font_size:3em;` while `css(font_size = "3em")` will return `font-size:3em`. (#402)

* `tagQuery()` no longer throws an error when attempting to traverse a NULL value with r-devel. (#407)

## Bug fixes

* `{htmltools}` now requires `{rlang}` version 1.0.0 or higher. (#403)
Expand Down
2 changes: 1 addition & 1 deletion R/tag_query.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1532,7 +1532,7 @@ tagQueryFindDescendants_ <- function(el, selector, fn) {
} else if (is.list(el)) {
# For each item in the list like object, recurse through
walk(el, tagQueryFindDescendants_, fn = fn, selector = selector)
} else if (is.atomic(el) || is.function(el) || is.language(el)) {
} else if (is.null(el) || is.atomic(el) || is.function(el) || is.language(el)) {
# Can not match on atomics or functions
return()
} else {
Expand Down