Skip to content

Explicitly include NULL as a value that tagQueryFindDescendants_() shouldn't traverse #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2023
Merged

Explicitly include NULL as a value that tagQueryFindDescendants_() shouldn't traverse #408

merged 2 commits into from
Oct 3, 2023

Conversation

@cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Oct 2, 2023

Closes #407.

@cpsievert cpsievert requested a review from schloerke October 2, 2023 17:40
@cpsievert cpsievert mentioned this pull request Oct 2, 2023
Merged
@cpsievert cpsievert requested a review from gadenbuie October 3, 2023 15:30
gadenbuie
gadenbuie approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cpsievert cpsievert merged commit 6dddb58 into main Oct 3, 2023
@cpsievert cpsievert deleted the null-is-atomic branch October 3, 2023 15:51
cpsievert added a commit that referenced this pull request Oct 3, 2023
@cpsievert
Explicitly include NULL as a value that tagQueryFindDescendants_() sh…
a5fb3e7 
…ouldn't traverse (#408)
@cpsievert cpsievert mentioned this pull request Oct 3, 2023
Closed
cpsievert added a commit that referenced this pull request Oct 5, 2023
@cpsievert
Explicitly include NULL as a value that tagQueryFindDescendants_() sh…
3696315 
…ouldn't traverse (#408)
cpsievert added a commit that referenced this pull request Oct 6, 2023
@cpsievert
Explicitly include NULL as a value that tagQueryFindDescendants_() sh…
c53e843 
…ouldn't traverse (#408)
@cpsievert cpsievert mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gadenbuie gadenbuie gadenbuie approved these changes

@schloerke schloerke Awaiting requested review from schloerke

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unit test is failing on r-devel due to is.atomic(NULL) change

3 participants

@cpsievert @gadenbuie