Add rmw_get_clients_info_by_service and rmw_get_servers_info_by_service #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Minju, Lee <[email protected]>
This was referenced Jul 21, 2025
|
Pulls: ros2/rmw#371, ros2/rmw_implementation#238, ros2/rcl#1161, ros2/rclcpp#2569, ros2/rclpy#1307, #679, ros2/rmw_fastrtps#771, ros2/rmw_cyclonedds#499, ros2/rmw_connextdds#154, ros2/ros2cli#916
|
This was referenced Jul 21, 2025
|
@ahcorde i'd like to review this before we merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is a sub-process to support ros2/ros2cli#916. It implements
rmw_get_clients_info_by_serviceandrmw_get_servers_info_by_serviceas described in ros2/rmw#371.Is this user-facing behavior change?
No.
Did you use Generative AI?
Yes, generative AI (GPT-4.0) was used to refine comments.
Additional Information
These functions are similar to the existing
rmw_get_publishers_info_by_topicfunction. In DDS-based implementations, the graph cache does not store the service type hash, necessitating modifications to the discovery process. In contrast, Zenoh already supports storing the service type hash in the graph cache.