improved rcl_wait in the area of timeout computation and spurious wakeups #1146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 31, 2024 12:18
Signed-off-by: Janosch Machowinski <[email protected]>
Signed-off-by: Janosch Machowinski <[email protected]>
jmachowinski
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
This was referenced Mar 31, 2024
fujitatomoya
approved these changes
Apr 1, 2024
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm. i think this should work for failed cases https://ci.ros2.org/job/ci_linux/20668/testReport/.
@jmachowinski thank you very much for your effort including weekend!
I will start the CI. (I will exclude ros2/rclcpp#2469, to verify this specific PR 1st.)
Collaborator
|
CI:
|
Added special handling for timers with a clock that has time override enabled. For these timer we should not compute a timeout, as the waitset is waken up by the associated guard condition. Before this change, the waitset could wait up, because of an expected ready timer, that was acutally not ready, as the time update to the ROS_TIME had not yet arrived. Signed-off-by: Janosch Machowinski <[email protected]>
Contributor
Author
|
fixed the linting problem |
jmachowinski
force-pushed
the
timer_imporvements2
branch
from
10bb656 to
3191f3a
Compare
Collaborator
|
Full CI: (ros2/rclcpp#2469 is already merged)
|
Collaborator
|
https://ci.ros2.org/job/ci_windows/21389/testReport/junit/rclpy/flake8/A006____rclpy_node_py_989_20_/ is known issue, and unrelated to this PR. |
alsora
reviewed
Apr 3, 2024
alsora
reviewed
Apr 3, 2024
alsora
reviewed
Apr 3, 2024
alsora
reviewed
Apr 3, 2024
alsora
reviewed
Apr 3, 2024
alsora
approved these changes
Apr 3, 2024
mjcarroll
approved these changes
Apr 3, 2024
n8hui
added a commit
to n8hui/rcl
that referenced
this pull request
May 3, 2025
(cherry-picked from commit 2e9549c) Signed-off-by: Nathan Hui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues reported by #1142.
Fixed a bug that a ready override timer would not wake up the wait set.
Adopted the test to catch this condition.
@clalancette, @mjcarroll , @fujitatomoya , @wjwwood