fix: Make flaky timer tests work #1143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmachowinski
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
Contributor
Hm, that's surprising. It fails like 90% of the time locally for me. |
Contributor
|
Here's just Linux CI with this:
|
Contributor
|
Actually, the build farm is quiet, so here are jobs on all platforms just in case this fixes it:
|
…ncel Signed-off-by: Janosch Machowinski <[email protected]>
Contributor
Author
|
hm, still fails. |
Contributor
Author
This PR is obsolete and supersedes by #1146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix the regression that was reportet by @clalancette.
Note, it does not fail on my local machine, and therefore I can not verify if it fixes the issue.