Add Dockerfile #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I hadn't said anything yet, I was waiting for #3 to get merged so we can use Crystal and then merge this one. |
given mix of build dependencies
|
@esteve I've updated this PR for adding a Dockerfile to target the latest foxy support. Having a ready to build dev environment should really help with onboarding more contributors to the project. I was speaking with some rust mentors during RustConf 2020 last week, and they asked for an entrypoint to build and run the project as to get started. |
|
@lelongg , could you review this Dockerfile PR. It'd be really nice to to provide new contributors a concrete reference on how to build the rust client library from source in a reproducible environment. Many Rust users may not be familiar with ROS's dipdacies and build setup, and vice versa for ROS users. |
lelongg
approved these changes
Oct 27, 2020
esteve
added a commit
that referenced
this pull request
Oct 27, 2025
* Remove lockfiles from being tracked Signed-off-by: Michael X. Grey <[email protected]> * Port draft action implementation from #410 Signed-off-by: Michael X. Grey <[email protected]> * Rework readiness for waitables Signed-off-by: Michael X. Grey <[email protected]> * Reworking action server goal handle lifecycles Signed-off-by: Michael X. Grey <[email protected]> * Fleshing out the state machines for action server goals -- cancelling is WIP Signed-off-by: Michael X. Grey <[email protected]> * Finished action server goal state machine API -- need to finish action_server.rs Signed-off-by: Michael X. Grey <[email protected]> * Progress on action_server implementation Signed-off-by: Michael X. Grey <[email protected]> * Action server finished -- needs testing Signed-off-by: Michael X. Grey <[email protected]> * Creating action server and action goal receiver -- needs testing Signed-off-by: Michael X. Grey <[email protected]> * Introducing action clients into the wait set processing Signed-off-by: Michael X. Grey <[email protected]> * Incorporate action clients into wait sets Signed-off-by: Michael X. Grey <[email protected]> * Fleshing out implementation of action clients Signed-off-by: Michael X. Grey <[email protected]> * Implementing goal status client Signed-off-by: Michael X. Grey <[email protected]> * Implementing goal result client Signed-off-by: Michael X. Grey <[email protected]> * CancellationClient API in progress Signed-off-by: Michael X. Grey <[email protected]> * Finish action cancellation request API Signed-off-by: Michael X. Grey <[email protected]> * Finish API for action clients -- needs testing Signed-off-by: Michael X. Grey <[email protected]> * Link against rcl_action Signed-off-by: Michael X. Grey <[email protected]> * Add initial tests and improve ergonomics Signed-off-by: Michael X. Grey <[email protected]> * Add co-author credit Co-authored-by: Nathan Wiebe Neufeldt <[email protected]> Signed-off-by: Michael X. Grey <[email protected]> * Re-export traits from rosidl_runtime_rs Signed-off-by: Michael X. Grey <[email protected]> * Update bindings to include actions -- added script for automating the binding generation Signed-off-by: Michael X. Grey <[email protected]> * Apply cargo fmt Signed-off-by: Michael X. Grey <[email protected]> * Update bindings for kilted Signed-off-by: Michael X. Grey <[email protected]> * Update bindings for humble Signed-off-by: Michael X. Grey <[email protected]> * Update bindings for rolling Signed-off-by: Michael X. Grey <[email protected]> * Fix use of serde Signed-off-by: Michael X. Grey <[email protected]> * Use desktop image so it includes rcl_action which we need for action bindings Signed-off-by: Michael X. Grey <[email protected]> * Fix serde Signed-off-by: Michael X. Grey <[email protected]> * Finish documentation for GoalClientStream Signed-off-by: Michael X. Grey <[email protected]> * Enable serde for goal status info Signed-off-by: Michael X. Grey <[email protected]> * Fix action cancellation pipeline Signed-off-by: Michael X. Grey <[email protected]> * More trait re-exports Signed-off-by: Michael X. Grey <[email protected]> * Add tests for action cancellation Signed-off-by: Michael X. Grey <[email protected]> * Fix use of action client options Signed-off-by: Michael X. Grey <[email protected]> * Fix style Signed-off-by: Michael X. Grey <[email protected]> * Remove use of .clear_poison because it is not stable in 1.75 Signed-off-by: Michael X. Grey <[email protected]> * chore: revert bindings-related changes (#5) Signed-off-by: Esteve Fernandez <[email protected]> * update rosidl_runtime_rs for action support (#6) Signed-off-by: Esteve Fernandez <[email protected]> * revert bindings generation changes --------- Signed-off-by: Michael X. Grey <[email protected]> Signed-off-by: Michael X. Grey <[email protected]> Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: Nathan Wiebe Neufeldt <[email protected]> Co-authored-by: Esteve Fernandez <[email protected]>
esteve
added a commit
that referenced
this pull request
Oct 27, 2025
* Remove lockfiles from being tracked Signed-off-by: Michael X. Grey <[email protected]> * Port draft action implementation from #410 Signed-off-by: Michael X. Grey <[email protected]> * Rework readiness for waitables Signed-off-by: Michael X. Grey <[email protected]> * Reworking action server goal handle lifecycles Signed-off-by: Michael X. Grey <[email protected]> * Fleshing out the state machines for action server goals -- cancelling is WIP Signed-off-by: Michael X. Grey <[email protected]> * Finished action server goal state machine API -- need to finish action_server.rs Signed-off-by: Michael X. Grey <[email protected]> * Progress on action_server implementation Signed-off-by: Michael X. Grey <[email protected]> * Action server finished -- needs testing Signed-off-by: Michael X. Grey <[email protected]> * Creating action server and action goal receiver -- needs testing Signed-off-by: Michael X. Grey <[email protected]> * Introducing action clients into the wait set processing Signed-off-by: Michael X. Grey <[email protected]> * Incorporate action clients into wait sets Signed-off-by: Michael X. Grey <[email protected]> * Fleshing out implementation of action clients Signed-off-by: Michael X. Grey <[email protected]> * Implementing goal status client Signed-off-by: Michael X. Grey <[email protected]> * Implementing goal result client Signed-off-by: Michael X. Grey <[email protected]> * CancellationClient API in progress Signed-off-by: Michael X. Grey <[email protected]> * Finish action cancellation request API Signed-off-by: Michael X. Grey <[email protected]> * Finish API for action clients -- needs testing Signed-off-by: Michael X. Grey <[email protected]> * Link against rcl_action Signed-off-by: Michael X. Grey <[email protected]> * Add initial tests and improve ergonomics Signed-off-by: Michael X. Grey <[email protected]> * Add co-author credit Co-authored-by: Nathan Wiebe Neufeldt <[email protected]> Signed-off-by: Michael X. Grey <[email protected]> * Re-export traits from rosidl_runtime_rs Signed-off-by: Michael X. Grey <[email protected]> * Update bindings to include actions -- added script for automating the binding generation Signed-off-by: Michael X. Grey <[email protected]> * Apply cargo fmt Signed-off-by: Michael X. Grey <[email protected]> * Update bindings for kilted Signed-off-by: Michael X. Grey <[email protected]> * Update bindings for humble Signed-off-by: Michael X. Grey <[email protected]> * Update bindings for rolling Signed-off-by: Michael X. Grey <[email protected]> * Fix use of serde Signed-off-by: Michael X. Grey <[email protected]> * Use desktop image so it includes rcl_action which we need for action bindings Signed-off-by: Michael X. Grey <[email protected]> * Fix serde Signed-off-by: Michael X. Grey <[email protected]> * Finish documentation for GoalClientStream Signed-off-by: Michael X. Grey <[email protected]> * Enable serde for goal status info Signed-off-by: Michael X. Grey <[email protected]> * Fix action cancellation pipeline Signed-off-by: Michael X. Grey <[email protected]> * More trait re-exports Signed-off-by: Michael X. Grey <[email protected]> * Add tests for action cancellation Signed-off-by: Michael X. Grey <[email protected]> * Fix use of action client options Signed-off-by: Michael X. Grey <[email protected]> * Fix style Signed-off-by: Michael X. Grey <[email protected]> * Remove use of .clear_poison because it is not stable in 1.75 Signed-off-by: Michael X. Grey <[email protected]> * chore: revert bindings-related changes (#5) Signed-off-by: Esteve Fernandez <[email protected]> * update rosidl_runtime_rs for action support (#6) Signed-off-by: Esteve Fernandez <[email protected]> * revert bindings generation changes --------- Signed-off-by: Michael X. Grey <[email protected]> Signed-off-by: Michael X. Grey <[email protected]> Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: Nathan Wiebe Neufeldt <[email protected]> Co-authored-by: Esteve Fernandez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple Dockerfile that builds rclrs from source using the ros2 docker hub image from the official library. To improve user development, a .dockerignore file is also provided to help prevent inadvertently breaking the build cache when making none code changes. Most of this file is combined from github's .gitignore files for each language present.