Fix tests for using new get_node_options API
#840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
DasRoteSkelett,
VanshGehlot,
bmagyar,
destogl,
harderthan,
livanov93 and
sachinkum0009
christophfroehlich
requested changes
Nov 20, 2023
Contributor
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
LGTM, but please extend also the tutorial on writing new controllers to announce the new possibility.
saikishor
force-pushed
the
controller_node_options_method
branch
from
ac58998 to
8e4c33a
Compare
Member
Author
@christophfroehlich Done |
christophfroehlich
approved these changes
Nov 20, 2023
Contributor
|
This pull request is in conflict. Could you fix it @saikishor? |
saikishor
force-pushed
the
controller_node_options_method
branch
from
8e4c33a to
27640eb
Compare
Contributor
|
This pull request is in conflict. Could you fix it @saikishor? |
saikishor
force-pushed
the
controller_node_options_method
branch
from
27640eb to
e72ba34
Compare
Contributor
|
This pull request is in conflict. Could you fix it @saikishor? |
bmagyar
approved these changes
Jan 31, 2024
Member
Author
|
@bmagyar I'm fixing it now. I will push them in few min |
Member
Author
|
@bmagyar the semi-binary builds are passing now! |
pac48
pushed a commit
to pac48/ros2_controllers
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs: ros-controls/ros2_control#1169
This PR adds fixes to the tests to support using the new
get_node_optionsAPI that is present inside the controller interface