Generate Parameter Library for diff_drive_controller #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aprotyas,
arne48,
bmagyar,
destogl,
jaron-l,
progtologist and
rosterloh
Signed-off-by: Tyler Weaver <[email protected]>
tylerjw
force-pushed
the
gpl_diff_drive
branch
from
1349c05 to
808201b
Compare
tylerjw
commented
Oct 17, 2022
Comment on lines
-104
to
+108
| std::vector<std::string> left_wheel_names_; | ||
| std::vector<std::string> right_wheel_names_; | ||
| // std::vector<std::string> left_wheel_names_; | ||
| // std::vector<std::string> right_wheel_names_; |
There was a problem hiding this comment.
Why did we leave these commented out?
tylerjw
commented
Oct 17, 2022
| } | ||
| max_velocity: { | ||
| type: double, | ||
| default_value: .NAN, |
There was a problem hiding this comment.
NAN in a parameter breaks ROS2 python handling of parameters so commands like ros2 param dump stop working and throw a python exception. We probably should not use it as a default value.
4 tasks
|
This pull request is in conflict. Could you fix it @tylerjw? |
|
@bmagyar as the other PR was merged, should we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement of #386