-
Notifications
You must be signed in to change notification settings - Fork 408
[DiffDriveController] Use generate parameter library #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DiffDriveController] Use generate parameter library #386
Conversation
This pull request is in conflict. Could you fix it @pac48? |
…lers into generate_parameter_library_for_diff_drive � Conflicts: � diff_drive_controller/src/diff_drive_controller.cpp
a28962d
to
364c7d7
Compare
This pull request is in conflict. Could you fix it @pac48? |
1 similar comment
This pull request is in conflict. Could you fix it @pac48? |
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
==========================================
- Coverage 35.78% 32.53% -3.26%
==========================================
Files 189 7 -182
Lines 17570 664 -16906
Branches 11592 356 -11236
==========================================
- Hits 6287 216 -6071
+ Misses 994 156 -838
+ Partials 10289 292 -9997
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally! :D
This is an example PR of converting the parameter usage in differential drive controller to use https://github.com/PickNikRobotics/generate_parameter_library