Skip to content

Conversation

pac48
Copy link
Contributor

@pac48 pac48 commented Jul 21, 2022

This is an example PR of converting the parameter usage in differential drive controller to use https://github.com/PickNikRobotics/generate_parameter_library

@mergify
Copy link
Contributor

mergify bot commented Jul 23, 2022

This pull request is in conflict. Could you fix it @pac48?

pac48 added 2 commits July 27, 2022 09:47
…lers into generate_parameter_library_for_diff_drive

� Conflicts:
�	diff_drive_controller/src/diff_drive_controller.cpp
@pac48 pac48 marked this pull request as ready for review July 27, 2022 15:52
@pac48 pac48 force-pushed the generate_parameter_library_for_diff_drive branch from a28962d to 364c7d7 Compare July 27, 2022 19:28
@mergify
Copy link
Contributor

mergify bot commented Jul 30, 2022

This pull request is in conflict. Could you fix it @pac48?

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2022

This pull request is in conflict. Could you fix it @pac48?

@destogl destogl changed the title Generate parameter library for diff drive [DiffDriveController] Use generate parameter library Dec 3, 2022
@destogl destogl requested a review from tylerjw December 3, 2022 11:50
@codecov-commenter
Copy link

Codecov Report

Merging #386 (a6ad3a7) into master (e7f9962) will decrease coverage by 3.25%.
The diff coverage is 26.93%.

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   35.78%   32.53%   -3.26%     
==========================================
  Files         189        7     -182     
  Lines       17570      664   -16906     
  Branches    11592      356   -11236     
==========================================
- Hits         6287      216    -6071     
+ Misses        994      156     -838     
+ Partials    10289      292    -9997     
Flag Coverage Δ
unittests 32.53% <26.93%> (-3.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontroller/test/test_load_diff_drive_controller.cpp 12.50% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <13.33%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 20.00% <20.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 39.36% <35.67%> (ø)
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <100.00%> (ø)
...mand_controller/src/forward_command_controller.cpp
...ller/test/test_load_forward_command_controller.cpp
...ntroller/test/test_load_joint_state_controller.cpp
... and 191 more

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally! :D

@bmagyar bmagyar merged commit bc88acb into ros-controls:master Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants