Update include paths of GPL #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
bmagyar,
destogl,
erickisos,
mcbed,
mhubii and
progtologist
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ros2-master #264 +/- ##
============================================
Coverage 74.88% 74.88%
============================================
Files 24 24
Lines 1107 1107
Branches 86 86
============================================
Hits 829 829
Misses 231 231
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
added
the
backport-humble
saikishor
previously approved these changes
Jan 15, 2025
Member
|
I don't understand why ABI is breaking here |
Contributor
Author
ABI used main instead of testing, like we have in ros2_controllers for example |
saikishor
approved these changes
Jan 15, 2025
Member
saikishor
left a comment
saikishor
left a comment
There was a problem hiding this comment.
I think it makes sense to use testing here
Contributor
Author
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
(cherry picked from commit 4885811)
christophfroehlich
pushed a commit
that referenced
this pull request
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs release 0.4.0
for reference, see PickNikRobotics/generate_parameter_library#213