-
Notifications
You must be signed in to change notification settings - Fork 59
feat: add inbound listing method #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+264
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 4 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="src/emails/receiving/interfaces/list-inbound-emails.interface.ts">
<violation number="1" location="src/emails/receiving/interfaces/list-inbound-emails.interface.ts:7">
ListInboundEmail inherits the headers field and omits attachments.size, so the published type no longer matches the list API payload; callers would be told headers exist and size does not, contradicting the real response.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
Base automatically changed from
feat/move-attachments-inbound-method
to
canary
October 9, 2025 19:57
e1084df to
af64453
Compare
af64453 to
d123fa9
Compare
vieiralucas
approved these changes
Oct 9, 2025
gabrielmfern
pushed a commit
that referenced
this pull request
Oct 16, 2025
gabrielmfern
pushed a commit
that referenced
this pull request
Oct 17, 2025
lucasfcosta
added a commit
that referenced
this pull request
Oct 17, 2025
gabrielmfern
pushed a commit
that referenced
this pull request
Oct 21, 2025
gabrielmfern
pushed a commit
that referenced
this pull request
Oct 21, 2025
lucasfcosta
added a commit
that referenced
this pull request
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a method to list inbound emails through the route
/emails/receiving/:id. The method is calledresend.emails.receiving.list.Note that this PR is made on top of #667 to make the diff easier to read as it builds upon a few types there.
Summary by cubic
Added inbound email listing via GET /emails/receiving, exposed as resend.emails.receiving.list. It supports pagination and returns a lightweight list of messages.
New Features
Bug Fixes