feat: move attachment inbound methods to be nested #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
lucasfcosta
force-pushed
the
feat/move-emails-inbound-method
branch
from
1aa7565 to
f218d56
Compare
lucasfcosta
force-pushed
the
feat/move-attachments-inbound-method
branch
from
a089288 to
0da8392
Compare
lucasfcosta
force-pushed
the
feat/move-attachments-inbound-method
branch
from
0da8392 to
3450b80
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
vieiralucas
approved these changes
Oct 9, 2025
gabrielmfern
pushed a commit
that referenced
this pull request
Oct 16, 2025
gabrielmfern
pushed a commit
that referenced
this pull request
Oct 17, 2025
lucasfcosta
added a commit
that referenced
this pull request
Oct 17, 2025
gabrielmfern
pushed a commit
that referenced
this pull request
Oct 21, 2025
gabrielmfern
pushed a commit
that referenced
this pull request
Oct 21, 2025
lucasfcosta
added a commit
that referenced
this pull request
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #666 to make the attachment methods require nesting for receiving and sending. In other words, now you must call
resend.attachments.receiving.<method>instead of justresend.attachmentspassing aninboundId.Note that I also updated the argument so we pass an
emailIdgivenreceivingis already part of the path to use the desired method.Finally, worth mentioning that I did change the response to be
snake_casedlike all the other methods on the SDK. I previously was converting to camel cased because we discussed that on Slack but it was actually inconsistent with other methods.This is as per the RFC.
Summary by cubic
Moved inbound attachment APIs under attachments.receiving and renamed inboundId to emailId to align with the receiving scope. This is a breaking change.
Migration
Refactors