fix(json-logic): apply custom operators when calculating the final schema #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcardoso5
approved these changes
Oct 20, 2025
lukad
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the custom JSON Logic operators are only applied when a field's
handleValidationcallback is called. This works for custom JSON Logic validations, but not when a computed value needs a custom operator.This PR applies the custom JSON Logic operators also when creating the final schema.
As a side note, I've previously attempted to simply add the validators when calling
createHeadlessForm, but this affects all subsequent calls for different forms, since they all share the same JSON Logic instance (see #237).