fix(json-logic): add custom operators on headless form creation #237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all custom JSON Logic operators are applied ad-hoc when the validation functions are executed, and then removed afterwards. While this makes sense from the point of view of simulating a deterministic call to JSON Logic, other places on the form's lifecycle require these custom operators to be available.
This means that if a form is loaded with an initial value where a property needs a computed value that relies on a custom operator, the operator won't be available (as it's only added when a validation happens), thus throwing an error.
This PR simplifies the logic by adding all custom operators at once when the
createHeadlessFormis called, which happens only once per page load.