Skip to content

Add isTemplateRepo #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add isTemplateRepo #141

wants to merge 1 commit into from

Conversation

kidonng
Copy link
Member

@kidonng kidonng commented Jul 26, 2022

Not needed for now, but I think we might as well add this.

Unlike existing isArchivedRepo and pending isPublicRepo, we can't check a template repo against its label because:

So we check the repo icon like the repo-avatars feature.

@netlify
Copy link

netlify bot commented Jul 26, 2022

Deploy Preview for preview-for-github-url-detection ready!

Name Link
🔨 Latest commit ce5b440
🔍 Latest deploy log https://app.netlify.com/sites/preview-for-github-url-detection/deploys/62df5c6156465b0008375345
😎 Deploy Preview https://deploy-preview-141--preview-for-github-url-detection.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fregante
Copy link
Member

fregante commented Jul 26, 2022

Not needed for now, but I think we might as well add this

Disagree. There’s so much “we might as well add” and if we don’t use it it will just rot and we’ll never find out. This is why I ask why something is being added first. I made it super easy to propose, merge and release for this reason, so it can be done as needed without too much trouble.

We can keep this PR closed until it is needed.

@kidonng
Copy link
Member Author

kidonng commented Jul 26, 2022

I just think we probably should have a detection for every major repository type. And seeing this needs to be done differently from the existing ones I want to leave a note.

But you are right about checking for template and mirror (also absent) repos may not be very useful.

We can keep this PR closed until it is needed.

That's fine.

@kidonng kidonng closed this Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants