Skip to content

Add isPublicRepo #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Add isPublicRepo #140

merged 1 commit into from
Aug 16, 2022

Conversation

kidonng
Copy link
Member

@kidonng kidonng commented Jul 26, 2022

To be used in Refined GitHub (I think there may be several features could benefit from this)

I wonder why we didn't have this (until now)

Test URL: here

@netlify
Copy link

netlify bot commented Jul 26, 2022

Deploy Preview for preview-for-github-url-detection ready!

Name Link
🔨 Latest commit 42b068e
🔍 Latest deploy log https://app.netlify.com/sites/preview-for-github-url-detection/deploys/62df581e4aa12800088a4011
😎 Deploy Preview https://deploy-preview-140--preview-for-github-url-detection.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kidonng
Copy link
Member Author

kidonng commented Jul 26, 2022

Hmm, so we have a Netlify bot now, but I prefer Vercel :thinking:

@fregante
Copy link
Member

Vercel doesn’t prefer us so I had to switch. Organizations aren’t free on Vercel and even after contacting them they refused to allow it. So Netlify is just as good.

Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same applies: #141 (comment)

Merge only if ready to be used

@fregante
Copy link
Member

Meta: I think I disabled Netlify’s comments. The preview URLs are still available in the checks list

@kidonng
Copy link
Member Author

kidonng commented Aug 16, 2022

Given updates on refined-github/refined-github#5853 I'm merging this.

@kidonng kidonng merged commit 34f422d into main Aug 16, 2022
@kidonng kidonng deleted the isPublicRepo branch August 16, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants