Fix nested tabs issue #54 #91
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds off of @Msliberty's commit at themattliberty@c4b4eaf This one, however, doesn't assume that "that the Tab node will always be the grandchild of the Tabs component node".
|
+1 |
This was referenced Jun 10, 2016
danez
added a commit
that referenced
this pull request
Jun 11, 2016
|
Thanks for your PR this is now fixed as of 9b5eeae |
|
Is this now fixed in the current version? |
|
@kirankashalkar yep, it is! 😄 |
|
What version is this exactly fixed in? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds off of @Msliberty's PR #61
This one, however, doesn't assume that "that the Tab node will always be the grandchild of the Tabs component node". Just that it will be a descendant. Feedback is welcome.