Skip to content

Conversation

themattliberty
Copy link

This patch assumes that the Tab node will always be the grandchild of the Tabs component node.

@mzabriskie
Copy link
Member

Will you update your PR to not include the changes in dist/?

@jamesaevans
Copy link

Would appreciate a merge here, if convenient. Thanks!

@rfreling
Copy link

Would also appreciate a merge. Thanks!

@joepvl
Copy link
Collaborator

joepvl commented Feb 19, 2016

I'd like to use nested tabs in a project and am looking for some clarity on this PR. @mzabriskie would you like @Msliberty to rebase so the changes to dist/ don't show up in the repo history or are you fine merging this as it is and just haven't gotten around to it?

@themattliberty
Copy link
Author

Sorry about that. I have rebased my PR onto the latest master. The tests pass locally; I'm not sure why it's failing on Travis.

Let me know if there's anything else I can do :)

@joepvl
Copy link
Collaborator

joepvl commented Feb 29, 2016

@Msliberty apparently there's a problem with mzabriskie/rackt-cli and npm 3.x (see issues in that repo for more info). That needs to be fixed first, the package updated on npm, and the dep updated in this repo, before the tests will pass again on Travis CI.
Alternatively, perhaps changing the Node version to 4 in .travis.yml would work as a temp fix? I'm not sure if builds were universally broken before it was set to 5. I'll check that out.

EDIT: So I checked it out; changing the Node version to 4 wasn't enough, but referring to mzabriskie/rackt-cli in package.json (instead of 0.5.4 on npm) did fix it. See #82.

@callmephilip
Copy link

i can confirm that this fixes the problem. would appreciate the merge. thanks @Msliberty!

happycollision added a commit to flixpressllc/ReactBasicTemplateEditor that referenced this pull request Apr 18, 2016
This is a copy and paste of the yet unmerged PR at
reactjs/react-tabs#61
@kirankashalkar
Copy link

Please merge. Thanks @Msliberty

@danez danez added the bug label Jun 10, 2016
@danez
Copy link
Collaborator

danez commented Jun 10, 2016

closing in favor of #91. Thanks.

@danez danez closed this Jun 10, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants