-
-
Notifications
You must be signed in to change notification settings - Fork 448
Fix nested Tabs (Issue #54) #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Will you update your PR to not include the changes in |
Would appreciate a merge here, if convenient. Thanks! |
Would also appreciate a merge. Thanks! |
I'd like to use nested tabs in a project and am looking for some clarity on this PR. @mzabriskie would you like @Msliberty to rebase so the changes to |
9777cab
to
c4b4eaf
Compare
Sorry about that. I have rebased my PR onto the latest master. The tests pass locally; I'm not sure why it's failing on Travis. Let me know if there's anything else I can do :) |
@Msliberty apparently there's a problem with mzabriskie/rackt-cli and npm 3.x (see issues in that repo for more info). That needs to be fixed first, the package updated on npm, and the dep updated in this repo, before the tests will pass again on Travis CI. EDIT: So I checked it out; changing the Node version to |
i can confirm that this fixes the problem. would appreciate the merge. thanks @Msliberty! |
This is a copy and paste of the yet unmerged PR at reactjs/react-tabs#61
Please merge. Thanks @Msliberty |
closing in favor of #91. Thanks. |
This patch assumes that the Tab node will always be the grandchild of the Tabs component node.