Avoid counting nulls and creating null mask in groupby aggregation MERGE_M2
#20716
+9
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
ttnghia
added
libcudf
Contributor
|
This should be probably be marked as a breaking-change since the expected output has changed. |
ttnghia
added
breaking
lamarrr
approved these changes
Nov 24, 2025
Contributor
lamarrr
left a comment
lamarrr
left a comment
There was a problem hiding this comment.
Changes LGTM.
Thanks for working on this
kingcrimsontianyu
approved these changes
Nov 24, 2025
Contributor
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the kernel call to
cudf::valid_ifto generate nullmask/null count during the computation of groupby aggregationMERGE_M2. Such null count is unnecessary as the output is already makes sense without nulls: if the input values of a group are all nulls, its output will have count valid field is0and that is enough for all further computation, no need to know the null count as well as the null mask for other output fields (avgandm2).