fix: Fix doc typos in driven_controls/predefined.py #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expressions for the CORPSE angle $\theta^3$ in the doc strings of `new_corpse_control`, and the three methods `new_corpse_in_*_control`, were missing a $\sin^{-1}$. The code looks correct.
leoadec
changed the title
|
Hi @FlorianH-1QBit, thanks for the PR! There was an issue in our PR workflow and should be fixed now. Can you merge the change to your branch, then the CI issue would be resolved. |
|
I've merged the change into my branch! |
Hi @FlorianH-1QBit, there was another CI issue on our end and should be fixed now. If you can pull the master again, hopefully everything would work this time. |
tachikoma-li
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expressions for the CORPSE angle$\theta^3$ in the doc strings of $\sin^{-1}$ . This PR adds the sin^{-1} in four places. The code itself looks correct.
new_corpse_control, and the three methodsnew_corpse_in_*_control, were missing a