Delete unused tracing functions from ops.cpp.
#9240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `SgnOp` and `SignOp`
- Full codegen migration: #3577
- Mistakenly re-introduced: #3572
- `LogSigmoid`
- Introduced: #3539
- Full codegen migration: #3743
- `SiLU`
- Introduced: #2721
- Full codegen migration: #3780
- `SiLUBackward`
- Introduced: #3195
- Full codegen migration: #3780
- `SeLU`
- Introduced: #3547
- Full codegen migration: #3780
- `Sigmoid`
- Introduced: 6a73deb (no PR record)
- Full codegen migration: #6342
bhavya01
approved these changes
May 23, 2025
|
The CI failure is the same as issue #9220. |
pgmoka
pushed a commit
that referenced
this pull request
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deletes a handful of unused tracing functions for the following operations. They are operations that are being full-codegen'd, but weren't deleted at that time. Note that a few of them were being used on unused tracing functions inside
tensor_methods.cpp. Those were also deleted.SgnOpandSignOpsgn,sign#3577LogSigmoidSiLUSiLUBackwardSeLUSigmoid