Skip to content

[ET-VK][ez] Fix vulkan_schema interface and link Vulkan to pybindings #13327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 12, 2025

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Aug 12, 2025

Summary:

Changes

First, small update to vulkan_schema interface in the CMakeLists.txt, which fixes a build error like:

  CMake Error in backends/vulkan/CMakeLists.txt:
    Target "vulkan_schema" INTERFACE_INCLUDE_DIRECTORIES property contains
    path:

      "/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/schema/include"

    which is prefixed in the build directory.

Then, make the pybindings link against to the vulkan backend if it is built. This allows model testing through Python via _load_for_executorch_from_buffer.

Test Plan:
CI

cc @manuelcandales @cbilgin

SS-JIA added 2 commits August 12, 2025 12:27
[ghstack-poisoned]
[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Aug 12, 2025
Copy link

pytorch-bot bot commented Aug 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13327

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending

As of commit 5730a1d with merge base 71c9a4f (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SS-JIA and others added 4 commits August 12, 2025 13:39
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Base automatically changed from gh/SS-JIA/280/head to main August 12, 2025 20:43
@SS-JIA SS-JIA merged commit 8edc6f0 into main Aug 12, 2025
100 of 101 checks passed
@SS-JIA SS-JIA deleted the gh/SS-JIA/281/head branch August 12, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants