Skip to content

[ET-VK] Add optional blocklist and allowlist to vulkan partitioner to aid debugging #13326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2025

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Aug 12, 2025

Summary:

Changes

  • Add operator_allowlist and operator_blocklist optional arguments to VulkanPartitioner
  • operator_blocklist will prevent operators in the block list to be lowered to Vulkan
  • operator_allowlist will only allow operators in the allow list to be lowered to Vulkan
  • operator_allowlist takes precedence over operator_blocklist

Context

When debugging models, it is useful to be able to prevent certain operators from being lowered to Vulkan, or to only allow certain operators from being lowered to Vulkan. This can help isolate which ops are causing model output to be incorrect.

Test Plan:

Test Plan

Tested this feature locally while debugging example models.

[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Aug 12, 2025
Copy link

pytorch-bot bot commented Aug 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13326

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending

As of commit fb3083d with merge base 71c9a4f (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@SS-JIA SS-JIA requested a review from manuelcandales August 12, 2025 16:28
SS-JIA and others added 2 commits August 12, 2025 13:39
[ghstack-poisoned]
[ghstack-poisoned]
@SS-JIA SS-JIA merged commit aa51149 into main Aug 12, 2025
101 of 102 checks passed
@SS-JIA SS-JIA deleted the gh/SS-JIA/280/head branch August 12, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants