Skip to content

forklift/legacy: fallback on all project users for GPG email #15004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2023
Merged

forklift/legacy: fallback on all project users for GPG email #15004

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18a986c
forklift/legacy: fallback on all project users for GPG email
woodruffw Dec 2, 2023
da9c806
Merge remote-tracking branch 'upstream/main' into ww/gpg-email-projec…
woodruffw Dec 4, 2023
47120c1
Merge remote-tracking branch 'upstream/main' into ww/gpg-email-projec…
woodruffw Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion warehouse/forklift/legacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,7 +1142,9 @@ def file_upload(request):
"provided signature has been discarded."
)
send_gpg_signature_uploaded_email(
request, request.user, project_name=project.name
request,
request.user if request.user else project.users,
Copy link
Member Author

@woodruffw woodruffw Dec 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: Passing in either a scalar user or list[user] here is allowed by @email-decorated APIs, like send_gpg_signature_uploaded_email.

project_name=project.name,
)

# TODO: This should be handled by some sort of database trigger or
Expand Down