forklift/legacy: fallback on all project users for GPG email #15004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <[email protected]>
woodruffw
commented
Dec 2, 2023
| send_gpg_signature_uploaded_email( | ||
| request, request.user, project_name=project.name | ||
| request, | ||
| request.user if request.user else project.users, |
Member
Author
There was a problem hiding this comment.
NB: Passing in either a scalar user or list[user] here is allowed by @email-decorated APIs, like send_gpg_signature_uploaded_email.
di
approved these changes
Dec 4, 2023
Member
|
@woodruffw The branch is out of date, and I can't update it, can you? |
Member
Author
|
Done! |
Member
|
Oops, one more time please, #14949 just got merged (not sure why I'm missing the ability to do this on your fork). |
Member
Author
This is a GitHub bug 🙃 -- the fork is on an org account ( (I can manually make you a maintainer on my fork however, one sec.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a distribution is uploaded via Trusted Publishing and is accompanied by a PGP signature, send the GPG deprecation email to all project members, rather than exploding due to
request.usernot being present.Fixes #14928.