Skip to content

Fixed overriding user provided mp_ctx strings to pm.sample() on M1 MacOS #6363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Fixed overriding user provided mp_ctx strings to pm.sample() on M1 MacOS #6363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pymc/sampling/parallel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,9 +386,13 @@ def __init__(
if mp_ctx is None or isinstance(mp_ctx, str):
# Closes issue https://github.com/pymc-devs/pymc/issues/3849
# Related issue https://github.com/pymc-devs/pymc/issues/5339
if platform.system() == "Darwin":
if mp_ctx is None and platform.system() == "Darwin":
if platform.processor() == "arm":
mp_ctx = "fork"
logger.debug(
"mp_ctx is set to 'fork' for MacOS with ARM architecture. "
+ "This might cause unexpected behavior with JAX, which is inherently multithreaded."
)
else:
mp_ctx = "forkserver"

Expand Down