Fixed overriding user provided mp_ctx strings to pm.sample() on M1 MacOS
#6363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
approved these changes
Dec 2, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6363 +/- ##
==========================================
- Coverage 94.72% 94.72% -0.01%
==========================================
Files 132 132
Lines 26740 26741 +1
==========================================
Hits 25330 25330
- Misses 1410 1411 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Per #6362, when the user provides a
strtomp_ctxon ARM-based Macs, this string will be overridden without warnings to"fork", which might be incompatible with some JAX operations in parallel settings. This change was introduced in #6218.Closes #6362
Bugfixes / New features
strs are not overridden."fork"and JAX.