Deprecate assert_negative_support
#5963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5963 +/- ##
==========================================
- Coverage 89.42% 89.38% -0.04%
==========================================
Files 73 73
Lines 13292 13249 -43
==========================================
- Hits 11886 11843 -43
Misses 1406 1406
|
michaelosthege
approved these changes
Jul 10, 2022
There was a problem hiding this comment.
Looks good to me!
@ricardoV94 do you want to give it a final look & merge since you opened the original issue?
ricardoV94
approved these changes
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
The
assert_negative_supportfunction is deprecated as mentioned in issue #5162. Me and @pibieta removed the function calls and added anDeprecationWarning.#DataUmbrellaPyMCSprint
Cc: @reshamas