-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Description
Remove calls to the assert_negative_support
In relation to the issue #5162 where the calls to the assert_negative_support
function were removed. We should also remove the calls of this function inside the Multivariate
module, the only class that uses this function is StickBreakingWeights
.
pymc/pymc/distributions/multivariate.py
Lines 2286 to 2294 in f9e0dfd
@classmethod | |
def dist(cls, alpha, K, *args, **kwargs): | |
alpha = at.as_tensor_variable(floatX(alpha)) | |
K = at.as_tensor_variable(intX(K)) | |
assert_negative_support(alpha, "alpha", "StickBreakingWeights") | |
assert_negative_support(K, "K", "StickBreakingWeights") | |
return super().dist([alpha, K], **kwargs) |
Moreover, the function is being imported from the continuous.py
:
pymc/pymc/distributions/multivariate.py
Lines 46 to 51 in f9e0dfd
from pymc.distributions.continuous import ( | |
BoundedContinuous, | |
ChiSquared, | |
Normal, | |
assert_negative_support, | |
) |
that will be deprecated in future versions of pyMC. Shouldn't we remove the calls and the import from this module?
#DataUmbrellaPyMCSprint
cc: @reshamas, @vitaliset, @ricardoV94, @OriolAbril
larryshamalamavitaliset, reshamas, OriolAbril and larryshamalama
Metadata
Metadata
Assignees
Labels
No labels