Skip to content

fix: pubnub.yml validation issues #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 11, 2021
Merged

fix: pubnub.yml validation issues #39

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
137ee2c
fix: pubnub.yml validation issues
Salet Mar 9, 2021
1de306d
fix: race condition in subscribeSpec
Salet Mar 10, 2021
e40153f
buiild: remove SourceClear
Salet Mar 10, 2021
08e591a
build: update node
Salet Mar 10, 2021
0e2e8f8
build: update yarn.lock
Salet Mar 10, 2021
ed1ed4e
fix: update pubnub.yml date format
Salet Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pubnub.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ changelog:
changes:
- type: bug
text: add functions to (fetchMessages and deleteMessages) to declaration files for TS
date: Aug 6, 2018
Copy link

@crimsonred crimsonred Mar 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that there is a date format check now. This is not valid anymore, the format it accepts will be 2018-08-06

Copy link
Contributor Author

@Salet Salet Mar 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. It's now switched to the format you mentioned

- version: v1.3.0
changes:
- type: feature
Expand Down
3 changes: 1 addition & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
language: node_js
sudo: false
node_js:
- '6'
- '10'
env:
- CXX=g++-4.8
addons:
srcclr: true
apt:
sources:
- ubuntu-toolchain-r-test
Expand Down
16 changes: 9 additions & 7 deletions test/e2e/subscribeSpec.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,17 +88,19 @@ describe('#subscribe()', function () {
pubnub.getInstance('another2').init(config.demo);

listener = {
message: function (m) {
expect(m.message).to.be.equal(stringMessage);
done();
}
};
message: function (m) {
expect(m.message).to.be.equal(stringMessage);
done();
},
status: function (st) {
expect(st.category).to.be.equal("PNConnectedCategory");
pubnub.getInstance('another2').publish({channel: channelName, message: stringMessage});
},
};

pubnub.getInstance('another2').addListener(listener);

pubnub.getInstance('another2').subscribe({channels: [channelName]});

pubnub.getInstance('another2').publish({channel: channelName, message: stringMessage});
});
});

Expand Down