-
Notifications
You must be signed in to change notification settings - Fork 13
fix: pubnub.yml validation issues #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.pubnub.yml
Outdated
| changes: | ||
| - type: bug | ||
| text: add functions to (fetchMessages and deleteMessages) to declaration files for TS | ||
| date: Aug 6, 2018 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that there is a date format check now. This is not valid anymore, the format it accepts will be 2018-08-06
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. It's now switched to the format you mentioned
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=========================================
Coverage ? 91.66%
=========================================
Files ? 1
Lines ? 324
Branches ? 0
=========================================
Hits ? 297
Misses ? 27
Partials ? 0
Continue to review full report at Codecov.
|
crimsonred
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.