Skip to content

Conversation

@Salet
Copy link
Contributor

@Salet Salet commented Mar 9, 2021

No description provided.

.pubnub.yml Outdated
changes:
- type: bug
text: add functions to (fetchMessages and deleteMessages) to declaration files for TS
date: Aug 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that there is a date format check now. This is not valid anymore, the format it accepts will be 2018-08-06

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. It's now switched to the format you mentioned

@codecov-io
Copy link

codecov-io commented Mar 10, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@b704d40). Click here to learn what that means.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #39   +/-   ##
=========================================
  Coverage          ?   91.66%           
=========================================
  Files             ?        1           
  Lines             ?      324           
  Branches          ?        0           
=========================================
  Hits              ?      297           
  Misses            ?       27           
  Partials          ?        0           
Impacted Files Coverage Δ
dist/pubnub-angular2.js 91.66% <94.73%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b704d40...0e2e8f8. Read the comment docs.

@Salet Salet requested a review from crimsonred March 10, 2021 17:23
Copy link

@crimsonred crimsonred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Salet Salet merged commit 0edba81 into master Mar 11, 2021
@Salet Salet deleted the fix/pubnub.yml branch March 11, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants