Fix #2351 & cleanup AddToCollectionList component

[lindapaiste]

Fixes #2363
Fixes #2351
Progress on #2179

Changes:

• Convert AddToCollectionList to a function component.
• The only prop needed is projectId -- the id of the project to add to the chosen collection.
• Access Redux state via useSelector and useDispatch.
• Return a Promise from the getCollections action so that the component knows when loading is complete.
• Delete the getProject fetch as the project details are not used.
• Delete the if condition on the title as a user is always adding to their own collections, even when it's another user's project.
  • AddToCollectionList.AnothersTitle can be removed from translation files, but I didn't do this.
• Delete so many PropTypes.
• Delete imports for unused action creators (see mapStateToProps and mapDispatchToProps often include unused props #2179). Only /actions/collections is used. The other four are not needed.
• Removed over 100 lines!

I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number, i.e. Fixes #123

[PiyushChandra17]

Nicely Done

[raclim]

Thanks for working on this!

I fixed some merge conflicts and also updated the props passed in IDEOverlays to reflect the new changes. Besides that, I don't think there should be any other major additional changes, but let me know if you spot anything!

[lindapaiste]

Thanks for working on this!

I fixed some merge conflicts and also updated the props passed in IDEOverlays to reflect the new changes. Besides that, I don't think there should be any other major additional changes, but let me know if you spot anything!

@raclim there is definitely in a problem in the IDEOverlays. There is no this.state so projectId={this.state.sketchToAddToCollection.id} won't work. It looks like we want to keep the projectId={params.project_id} there and the only change to that file is to remove the line username={params.username}.

[raclim]

Thanks for catching that! I'll create a new issue now to quickly update it.