-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Closed
Labels
EnhancementImprovement to an existing featureImprovement to an existing feature
Milestone
Description
Increasing Access
It keeps the codebase up to date and makes it easier for new contributors.
Feature enhancement details
React.Component is considered a legacy API and is not recommended. We should convert all class components to function components which use React hooks.
This is mainly a "Progress Report" for myself because with so many unmerged PRs sometimes I forget what I've already worked on!
Here are the class components which remain the codebase, and the PRs to convert them:
- EmailVerificationView
- App Convert
Appto a function component. #2308 - Overlay Convert
Overlayto a function component, shares logic withModal#2309 - AddToCollectionList Fix #2351 & cleanup
AddToCollectionListcomponent #2353 - AddToCollectionSketchList Convert
AddToCollectionSketchListto a function component #2364 - ConsoleInput
- CopyableInput Convert
CopyableInputto a function component #2360 - Editor -- this one is too annoying/difficult due to the potential for stale closures. It will likely wait until upgrading to codemirror v6, when the component needs a lot of changes anyways.
- FileNode
- Toolbar Convert
Toolbarto a function component #2352 - Preferences Convert
Preferencesinto a function component #2335 - Searchbar
- IDEView done by @dewanshDT, not submitted yet
- APIKeyForm Convert
APIKeyFormto a function component and connect to Redux #2307 - Collection Convert
Collectionto a function component #2366 - CollectionView Delete unused code in
CollectionView#2302 - DashboardView
- Tables -- should be addressed together (see Create generic Table component #1442)
- SketchListRowBase
- SketchList Common Table component (part 1) #2376
- AssetListRowBase
- AssetList Common Table component (part 1) #2376
- CollectionListRowBase
- CollectionList Common Table component (part 1) #2376
dewanshDT, ahmad-04, Akshay02022 and Umesh-Mallipudi
Metadata
Metadata
Assignees
Labels
EnhancementImprovement to an existing featureImprovement to an existing feature
Type
Projects
Status
Done