Skip to content

ActionBar: Add aria-label to role="toolbar" #6980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ActionBar: Add aria-label to role="toolbar" #6980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f5f0f7
Add `aria-label` to `role="toolbar"`
TylerJDev Oct 10, 2025
6c2e5ef
Add changeset
TylerJDev Oct 10, 2025
7b2235f
Merge branch 'main' into tylerjdev/add-aria-label-toolbar-actionbar
TylerJDev Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thin-cobras-cry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

ActionBar: Supplies `aria-label` to toolbar inside of `ActionBar`
8 changes: 7 additions & 1 deletion packages/react/src/ActionBar/ActionBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,13 @@ export const ActionBar: React.FC<React.PropsWithChildren<ActionBarProps>> = prop
return (
<ActionBarContext.Provider value={{size, registerChild, unregisterChild, isVisibleChild}}>
<div ref={navRef} className={clsx(className, styles.Nav)} data-flush={flush}>
<div ref={listRef} role="toolbar" className={styles.List} style={{gap: `${ACTIONBAR_ITEM_GAP}px`}}>
<div
ref={listRef}
role="toolbar"
className={styles.List}
style={{gap: `${ACTIONBAR_ITEM_GAP}px`}}
aria-label={ariaLabel}
Copy link

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ariaLabel variable is being used but it's not defined in the component props or local scope. This will cause a runtime error.

Copilot uses AI. Check for mistakes.

>
{children}
{menuItemIds.size > 0 && (
<ActionMenu>
Expand Down
Loading