Skip to content

Conversation

TylerJDev
Copy link
Member

@TylerJDev TylerJDev commented Oct 10, 2025

Applies aria-label to the toolbar inside of ActionBar.

Changelog

Changed

  • Adds aria-label to role="toolbar"

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Oct 10, 2025

🦋 Changeset detected

Latest commit: 7b2235f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Patch
@primer/styled-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 10, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-6980 October 10, 2025 16:59 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6980 October 10, 2025 17:08 Inactive
@TylerJDev TylerJDev marked this pull request as ready for review October 10, 2025 22:05
@TylerJDev TylerJDev requested a review from a team as a code owner October 10, 2025 22:05
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds accessibility support to the ActionBar component by applying an aria-label attribute to the toolbar element. The change enhances screen reader compatibility by providing a descriptive label for the toolbar role.

Key Changes

  • Added aria-label attribute to the toolbar div element within ActionBar
  • Reformatted the toolbar div element for better readability
  • Added changeset for patch release documentation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/ActionBar/ActionBar.tsx Added aria-label attribute to toolbar element and reformatted for readability
.changeset/thin-cobras-cry.md Added changeset documenting the accessibility improvement

role="toolbar"
className={styles.List}
style={{gap: `${ACTIONBAR_ITEM_GAP}px`}}
aria-label={ariaLabel}
Copy link

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ariaLabel variable is being used but it's not defined in the component props or local scope. This will cause a runtime error.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant