Maintenance to Fedora CI infrastructure #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, thanks! |
|
I think this is ready for review |
|
LGTM. Nice work. The CI is green, and will stay green ;-). |
pboettch
approved these changes
Oct 8, 2025
|
When merging (who does it?) please squash. |
I think it does not really matter as long as there is an approval and we agree on how to merge it. I'm totally in for squashing. |
|
Meant to mention editing the title and description with relevant summary of the changes, but I see that it was not setup to automatically pick those so irrelevant for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots have changed since last I've added this. For now I will try to unblock @JohanMabille.
I believe last time there were issues with the test-suite not building properly (not having the
JSON_SCHEMA_TEST_SUITE_PATHpointing to an existing path or something along those lines), @JohanMabille I might not have the time to look into it, so if I disable it, can you work on that?