Upgrade to nlohmann json 3.12.0 #362
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LecrisUT
reviewed
Oct 3, 2025
.github/workflows/test.yaml
Outdated
| matrix: | ||
| toolchain: [ gcc, llvm, intel ] | ||
| json_version: [ v3.11.2, v3.8.0 ] | ||
| json_version: [ v3.12.0, v3.8.0 ] |
There was a problem hiding this comment.
You could also add main branch
JohanMabille
force-pushed
the
nlohmann_3_12
branch
from
494768d to
aaed7a0
Compare
JohanMabille
force-pushed
the
nlohmann_3_12
branch
from
aaed7a0 to
29d835d
Compare
|
Oooh, so happy seeing things being moved around. Looking forward to. Thanks already. |
|
@LecrisUT I have no idea how to fix the Fedora builds (I cannot access the logs). |
JohanMabille
force-pushed
the
nlohmann_3_12
branch
from
4fa186e to
f7715c1
Compare
|
Closing in favor of #363 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some CMake changes in dedicated commits that I can squash or remove if we don't agree on them (or if we find it better to move them to a dedicated PR):
- The tests require the example to be built(Reverted, will be fixed differently)- I homogenized the behavior regarding how we search for nlohmann_json dependency. Package managers should not fetch nlohmann_json source, so I set the finding on the system as te first option, and the fetch as the fallback.(Reverted, will be fixed differently)