fix(Toolbar): updated for parity with Core updates #10674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-10674.surge.sh A11y report: https://patternfly-react-pr-10674-a11y.surge.sh |
Closed
4 tasks
thatblindgeye
force-pushed
the
mattToolbarParity
branch
from
edac4d2 to
08b4d2e
Compare
mattnolting
reviewed
Jul 11, 2024
Contributor
mattnolting
left a comment
mattnolting
left a comment
There was a problem hiding this comment.
Excellent work, thank you! Here's what I noticed.
thatblindgeye
requested review from
a team,
kmcfaul and
tlabaj
and removed request for
a team
mattnolting
approved these changes
Jul 11, 2024
Contributor
mattnolting
left a comment
mattnolting
left a comment
There was a problem hiding this comment.
This guy's good, LPTM. Well done @thatblindgeye 👍
nicolethoen
approved these changes
Jul 12, 2024
tlabaj
approved these changes
Jul 15, 2024
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10639
Will need to wait to pull in Core updates for modifier classes/styling.
Placeholder Codmod issue: patternfly/pf-codemods#677
Additional issues: