Wizard Enhancements (4.x) #460
Conversation
test/wizard/wizard.spec.js
Outdated
| $timeout.flush(); | ||
| }); | ||
| // $timeout.flush(); | ||
| // $timeout.flush(); |
src/wizard/wizard.component.js
Outdated
| hideBackButton: '@', | ||
| sidebarClass: '@', | ||
| stepClass: '@', | ||
| contentHeight: '=?', currentStep: '<?', |
There was a problem hiding this comment.
is currentStep: '<?', really on the same line as contentHeight?
jeff-phillips-18
force-pushed
the
branch-4.0-dev
branch
from
82716fc to
81a1639
Compare
| element = compileHtml(modalHtml, $scope); | ||
| $scope.$digest(); | ||
|
|
||
| // there are two dependent timeouts in the wizard that need to be flushed |
There was a problem hiding this comment.
The comment used here relates a nice bit of info about the need for running concurrent $timeout.flush() Should we look at keeping at least one of them? (the comment)
There was a problem hiding this comment.
Sure, as long as there is a reason to :-)
There was a problem hiding this comment.
Indeed, could be labeled as... simply related to overall testing against multiple dependent components.
There was a problem hiding this comment.
They actually should be flushed here, rather that in each test only when critical for test passage. I've put them back with the comment. Also added a comment where we flush again when navigating to a specific page.
allow hiding header allow hiding the sidebar navigation panel allow hiding the back button (useful in 2 page wizards) add disabled class to step indicators when disabled allow adding a class to the sidebar and step panels rather than setting a height allow use of the wizard from typescript bases applications: The use of require ^ fails when being included in typescript so that has been removed and replaced by using scope to find the required Wizard/WizardStep controllers.
jeff-phillips-18
force-pushed
the
branch-4.0-dev
branch
from
81a1639 to
de9c36b
Compare
3 participants
The use of require ^ fails when being included in typescript so that has been removed and replaced by using scope to find the required Wizard/WizardStep controllers.
This is a port of #458