Wizard Enhancements #458
Merged
Wizard Enhancements #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwforres
reviewed
May 2, 2017
src/wizard/wizard-directive.js
Outdated
| * @param {boolean=} hideSidebar Hides page navigation sidebar on the wizard pages | ||
| * @param {boolean=} hideHeader Optional value to hide the title bar. Default is false. | ||
| * @param {string=} stepClass Optional CSS class to be given to the steps page container. Used for the sidebar panel as well unless a sidebarClass is provided. | ||
| * @param {string=} aidebarClass Optional CSS class to be give to the aidebar panel. Only used if the stepClass is also provided. |
There was a problem hiding this comment.
noticed typo in two places aidebar -> sidebar
dtaylor113
approved these changes
May 3, 2017
cdcabrera
reviewed
May 3, 2017
Member
cdcabrera
left a comment
cdcabrera
left a comment
There was a problem hiding this comment.
Appears the "wizard-review-page-directive" directive still makes use of the "require", is that going to interfere with anything?
allow hiding header allow hiding the sidebar navigation panel allow hiding the back button (useful in 2 page wizards) add disabled class to step indicators when disabled allow adding a class to the sidebar and step panels rather than setting a height allow use of the wizard from typescript bases applications
Member
Author
|
Thanks @cdcabrera, I have updated the review page as well. |
cdcabrera
approved these changes
May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of require ^ fails when being included in typescript so that has been removed and replaced by using scope to find the required Wizard/WizardStep controllers.
@jwforres @spadgett @rhamilto