Skip to content

Wrap wizard button in an IIFE to prevent access globally. #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2016
Merged

Wrap wizard button in an IIFE to prevent access globally. #331

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dca654
Wrap wizard button in an IIFE to prevent access globally.
dgutride Oct 25, 2016
a5906f0
Rename function
dgutride Oct 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 28 additions & 27 deletions src/wizard/wizard-buttons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,31 @@
function wizardButtonDirective (action) {
(function () {
'use strict';

angular.module('patternfly.wizard')
.directive(action, function () {
return {
restrict: 'A',
require: '^pf-wizard',
scope: {
callback: "=?"
},
link: function ($scope, $element, $attrs, wizard) {
$element.on("click", function (e) {
e.preventDefault();
$scope.$apply(function () {
// scope apply in button module
$scope.$eval($attrs[action]);
wizard[action.replace("pfWiz", "").toLowerCase()]($scope.callback);
function pfWizardButtonDirective (action) {
angular.module('patternfly.wizard')
.directive(action, function () {
return {
restrict: 'A',
require: '^pf-wizard',
scope: {
callback: "=?"
},
link: function ($scope, $element, $attrs, wizard) {
$element.on("click", function (e) {
e.preventDefault();
$scope.$apply(function () {
// scope apply in button module
$scope.$eval($attrs[action]);
wizard[action.replace("pfWiz", "").toLowerCase()]($scope.callback);
});
});
});
}
};
});
}
}
};
});
}

wizardButtonDirective('pfWizNext');
wizardButtonDirective('pfWizPrevious');
wizardButtonDirective('pfWizFinish');
wizardButtonDirective('pfWizCancel');
wizardButtonDirective('pfWizReset');
pfWizardButtonDirective('pfWizNext');
pfWizardButtonDirective('pfWizPrevious');
pfWizardButtonDirective('pfWizFinish');
pfWizardButtonDirective('pfWizCancel');
pfWizardButtonDirective('pfWizReset');
})();
Copy link
Member

@jeff-phillips-18 jeff-phillips-18 Oct 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still like to see these function prefixed with pf. For example, pfWizardButtonDirective('pfWizNext')