Wrap wizard button in an IIFE to prevent access globally. #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtaylor113
approved these changes
Oct 25, 2016
jeff-phillips-18
requested changes
Oct 25, 2016
| wizardButtonDirective('pfWizFinish'); | ||
| wizardButtonDirective('pfWizCancel'); | ||
| wizardButtonDirective('pfWizReset'); | ||
| })(); |
Member
There was a problem hiding this comment.
I would still like to see these function prefixed with pf. For example, pfWizardButtonDirective('pfWizNext')
jeff-phillips-18
approved these changes
Oct 25, 2016
Member
jeff-phillips-18
left a comment
jeff-phillips-18
left a comment
There was a problem hiding this comment.
👍 LGTM
Thanks @dgutride!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManageIQ identified an issue with this function because the same function had been defined globally in their codebase. This wraps the function an IIFE which causes the directives to be immediately created and the function is disposed of (and not available on the window object any longer).
Testing done:
Prior to the fix - wizardButtonDirective() can be called in the console when the wizard code is loaded, afterwards, the directives are created upon load and then the function isn't available globally.