handle overwrite cancel and remove overlay plugin #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
added a commit
that referenced
this pull request
Oct 30, 2015
handle overwrite cancel and remove overlay plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
keeps the file save button options the same after an overwrite dialog is canceled, as well as some refactoring of the overlay statement into the router
Where should the reviewer start?
the save overlay view and the handlers
How should this be manually tested?
Create a new file then navigate away from it. When the save dialog appears, try saving the file with an name already being used. The click cancel on the overwrite dialog. You should still have three option buttons on the save dialog. Also, test the various other dialogs in the app.
What are the relevant tickets?
fixes #276