Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Adds a custom
Card
component instead of using the one provided by react-material, which had some styling that caused scrollbars to not be clickable. This custom one has only the bare minimum styling. The shadow on the edge of the custom card may be less pronounced because the react-material library was using a bunch of elements to generate its shadow.What are the important parts of the code?
src/components/card.js
has the definition of the customCard
component, it is then swapped out insrc/components/overlay.js
andsrc/components/sidebar.js
. Changes were also made tosrc/components/projects-button.js
because we no longer havepostition: relative
on the card component to contain it (again, because we only want the minimum styles).How should this be tested by the reviewer?
Is any other information necessary to understand this?
Everything should be outlined above.
What are the relevant tickets? (Please add
closes
,refs
, etc)Fixes #277
Fixes #290
Screenshots (if appropriate)
Very hard to capture this on OSX 😞