new version overlay #262
Merged
new version overlay #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -244,6 +244,17 @@ function handlers(app, opts, done){ | |||
| store.dispatch(creators.showDeleteFileOverlay()); | |||
| } | |||
|
|
|||
| function showNewVersionOverlay(){ | |||
| chrome.storage.local.get('newVersion', function(val) { | |||
| console.log('newVersion', val.newVersion); | |||
|
updated |
|
needs a rebase |
monteslu
force-pushed
the
newVersionOverlay
branch
from
b8c5a64 to
f890614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Adds an overlay when a new version or new installation of the app occurs.
Where should the reviewer start?
start with client.js to see the lifecycle of the check, and background.js to see how the app is flagged as updated.
How should this be manually tested?
build and reload the app, when launching it should show the overlay. If you just close and re-open without reload or re-installing the overlay should not appear.
What are the relevant tickets?
fixes #215