Skip to content

ci: hive tests #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Apr 21, 2023
Merged

ci: hive tests #1348

merged 48 commits into from
Apr 21, 2023

Conversation

@Rjected
Copy link
Member

@Rjected Rjected commented Feb 14, 2023 •
edited
Loading

Working PR to run ethereum/hive tests in CI. This sets up a matrix so each test suite can be run concurrently after building the reth image.

Failures tracked in #1579

Closes #855

@Rjected Rjected added A-utils Related to commonly used utilities C-test A change that impacts how or what we test labels Feb 14, 2023
onbjerg
onbjerg reviewed Feb 14, 2023
View reviewed changes
onbjerg
onbjerg reviewed Feb 14, 2023
View reviewed changes
@onbjerg onbjerg changed the title feat: run hive tests in CI ci: hive tests Feb 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023 •
edited
Loading

Codecov Report

Merging #1348 (3b5bfc0) into main (d300057) will decrease coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1348      +/-   ##
==========================================
- Coverage   72.08%   72.07%   -0.01%     
==========================================
  Files         476      480       +4     
  Lines       57476    58129     +653     
==========================================
+ Hits        41430    41895     +465     
- Misses      16046    16234     +188
Flag Coverage Δ
integration-tests 18.85% <ø> (-0.23%) ⬇️
unit-tests 66.82% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 45 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gakonst
gakonst reviewed Feb 15, 2023
View reviewed changes
.github/workflows/hive.yml Outdated
Comment on lines 62 to 64
Copy link
Member

@gakonst gakonst Feb 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

gakonst
gakonst reviewed Feb 15, 2023
View reviewed changes
@Rjected Rjected force-pushed the dan/hive-ci branch 4 times, most recently from d0a1b83 to 9c08a10 Compare February 16, 2023 23:36
@gakonst gakonst marked this pull request as ready for review February 17, 2023 00:08
@Rjected Rjected force-pushed the dan/hive-ci branch 2 times, most recently from 0ebe9b6 to 0726acb Compare February 17, 2023 20:42
@gakonst gakonst force-pushed the dan/hive-ci branch 2 times, most recently from 8f46a8c to 602ada4 Compare February 21, 2023 03:37
@Rjected Rjected force-pushed the dan/hive-ci branch 4 times, most recently from 38cb2c0 to e9b3f09 Compare February 21, 2023 21:42
@Rjected Rjected mentioned this pull request Feb 21, 2023
Closed
@Rjected Rjected force-pushed the dan/hive-ci branch 6 times, most recently from 3e3d421 to 05787bb Compare February 26, 2023 00:59
Rjected and others added 22 commits April 20, 2023 17:35
@Rjected
create a new job per limit
bbb5fd6
@Rjected
use include for devp2p, so snap is excluded
7204daf
@Rjected
reorder matrix items
d58a06b
@Rjected
remove clique smoke test
d245459 
 * we do not support producing clique blocks yet, so this test will
   always fail, and is not applicable
@Rjected
remove ethereum/consensus from hive test workflow
f4cc74d
@Rjected
add consensus test nightly job
1e8e8b8
@Rjected
test multiple limits in parallel
7d00e7b
@Rjected
use separate job for ethereum/sync test
cd2ce8b
@Rjected
change name of ethereum sync job
128ab3f
@rakita @Rjected
bug: Insert storage/bytecode from genesis (#1759)
195db3a
@Rjected
remove TestLargeTxRequest
6190d57
@Rjected
put continuous in sync sim
efffc01
@Rjected
remove debug.tip fork due to continuous downloader
e77674a
@gakonst @Rjected
chore: remove commented out inspector code
7c31e33
@Rjected
split up rpc-compat methods
e3977ca
@Rjected
fix rpc-compat split
13240eb
@Rjected
remove historical eth_getProof test
223ffd5
@Rjected
remove issues test, add pyspec simulator
7d0fb5b
@Rjected
try to include getproof test that should work
a331df1
@Rjected
disable eth_getProof tests
23307da
@Rjected
comment out failing tests
ee061f1
@Rjected
remove consensus test suite for now
40ee36d
@gakonst gakonst merged commit 0664ee1 into main Apr 21, 2023
@gakonst gakonst deleted the dan/hive-ci branch April 21, 2023 17:45
@gakonst
Copy link
Member

gakonst commented Apr 21, 2023 •
edited
Loading

@Rjected Could you update the Hive tracker on what passes / what doesn't and what our next key areas of focus should be to further increase our Hive coverage? Please also share your Hive improvement bulletpoints, so we start upstreaming some of them or get feedback from EF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onbjerg onbjerg onbjerg left review comments

@gakonst gakonst gakonst approved these changes

@rakita rakita Awaiting requested review from rakita

Assignees

No one assigned

Labels

A-utils Related to commonly used utilities C-test A change that impacts how or what we test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Run ethereum/hive tests in CI

6 participants

@Rjected @codecov-commenter @gakonst @onbjerg @rakita