Skip to content

Conversation

@rakita
Copy link
Collaborator

@rakita rakita commented Mar 15, 2023

closing: #1746

Genesis (test setup) was not fully inserted inside the database (bytecode and storage were missing)

@rakita rakita requested a review from gakonst as a code owner March 15, 2023 04:28
@rakita rakita requested a review from Rjected March 15, 2023 04:30
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested + LGTM, nice!

@gakonst gakonst merged this pull request into dan/hive-ci Mar 15, 2023
@gakonst gakonst deleted the rakita/bug/insert_storage_bytecode_from_genesis branch March 15, 2023 06:12
@gakonst
Copy link
Member

gakonst commented Mar 15, 2023

makes sense - we didn't hit it because we'd use empty states in our testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants