Move chained assignment detection to cython for Python 3.14 compat #62070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Some commented-out code needs to be removed, otherwise looks nice |
jorisvandenbossche
force-pushed
the
cow-chained-detection-py314
branch
from
66cd359 to
efea93f
Compare
jorisvandenbossche
changed the title
7 tasks
|
Can you merge main to see if that fixes the ci |
…ill skips check for inplace methods
|
Only remaining failure is the free-threaded build, where a bunch of tests fail with a missing warning, because the check in cython does not seem to work for free-threaded python (https://github.com/pandas-dev/pandas/actions/runs/18678375696/job/53253518246?pr=62070). To move forward with this PR, will include "3.14+ and freethreaded" condition to the |
|
Is this ready? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft exploring a solution for #61368