cleanup

Author: jorisvandenbossche

pandas/_libs/internals.pyx

@@ -24,6 +24,8 @@ cnp.import_array()
 
 from pandas._libs.algos import ensure_int64
 from pandas.errors import ChainedAssignmentError
+from pandas.errors.cow import _chained_assignment_msg
+
 
 from pandas._libs.util cimport (
     is_array,
@@ -1005,10 +1007,7 @@ cdef class BlockValuesRefs:
 cdef extern from "Python.h":
     """
     #if PY_VERSION_HEX < 0x030E0000
-    int __Pyx_PyUnstable_Object_IsUniqueReferencedTemporary(PyObject *ref)
-    {
-        return 0;
-    }
+    int __Pyx_PyUnstable_Object_IsUniqueReferencedTemporary(PyObject *ref);
     #else
     #define __Pyx_PyUnstable_Object_IsUniqueReferencedTemporary \
         PyUnstable_Object_IsUniqueReferencedTemporary
@@ -1018,40 +1017,25 @@ cdef extern from "Python.h":
         "__Pyx_PyUnstable_Object_IsUniqueReferencedTemporary"(object o) except -1
 
 
+# Python version compatibility for PyUnstable_Object_IsUniqueReferencedTemporary
 cdef inline bint _is_unique_referenced_temporary(object obj) except -1:
     if PY_VERSION_HEX >= 0x030E0000:
+        # Python 3.14+ has PyUnstable_Object_IsUniqueReferencedTemporary
         return PyUnstable_Object_IsUniqueReferencedTemporary(obj)
     else:
+        # Fallback for older Python versions using sys.getrefcount
         return sys.getrefcount(obj) <= 1
 
 
-# # Python version compatibility for PyUnstable_Object_IsUniqueReferencedTemporary
-# IF PY_VERSION_HEX >= 0x030E0000:
-#     # Python 3.14+ has PyUnstable_Object_IsUniqueReferencedTemporary
-#     cdef inline bint _is_unique_referenced_temporary(object obj) except -1:
-#         return PyUnstable_Object_IsUniqueReferencedTemporary(obj)
-# ELSE:
-#     # Fallback for older Python versions using sys.getrefcount
-#     cdef inline bint _is_unique_referenced_temporary(object obj) except -1:
-#         # sys.getrefcount includes the reference from getrefcount itself
-#         # So if refcount is 2, it means only one external reference exists
-#         return sys.getrefcount(obj) == 2
-
-
-# @cython.auto_pickle(False)
 cdef class SetitemMixin:
+    # class used in DataFrame and Series for checking for chained assignment
 
-    def __setitem__(self, key, value):
+    def __setitem__(self, key, value) -> None:
         cdef bint is_unique = _is_unique_referenced_temporary(self)
-        # print("Refcount self: ", sys.getrefcount(self))
-        # print("Is unique referenced temporary: ", is_unique)
         if is_unique:
             warnings.warn(
-                "A value is trying to be set on a copy of a DataFrame or Series "
-                "through chained assignment.",
-                ChainedAssignmentError,
-                stacklevel=1,
-                )
+                _chained_assignment_msg, ChainedAssignmentError, stacklevel=1
+            )
         self._setitem(key, value)
 
     def __delitem__(self, key) -> None:

pandas/_libs/tslib.pyx

@@ -267,7 +267,6 @@ cpdef array_to_datetime(
     str unit_for_numerics=None,
 ):
     """
-    TODO no longer up to date
     Converts a 1D array of date-like values to a numpy array of either:
         1) datetime64[ns] data
         2) datetime.datetime objects, if OutOfBoundsDatetime or TypeError

pandas/core/frame.py

@@ -4218,6 +4218,7 @@ def isetitem(self, loc, value) -> None:
         arraylike, refs = self._sanitize_column(value)
         self._iset_item_mgr(loc, arraylike, inplace=False, refs=refs)
 
+    # def __setitem__() is implemented in SetitemMixin and dispatches to this method
     def _setitem(self, key, value) -> None:
         """
         Set item(s) in DataFrame by key.
@@ -4302,12 +4303,6 @@ def _setitem(self, key, value) -> None:
         z  3  50
         # Values for 'a' and 'b' are completely ignored!
         """
-        # if not PYPY:
-        #     if sys.getrefcount(self) <= 3:
-        #         warnings.warn(
-        #             _chained_assignment_msg, ChainedAssignmentError, stacklevel=2
-        #         )
-
         key = com.apply_if_callable(key, self)
 
         # see if we can slice the rows

pandas/core/generic.py

@@ -4258,7 +4258,7 @@ def _slice(self, slobj: slice, axis: AxisInt = 0) -> Self:
         result = result.__finalize__(self)
         return result
 
-    # __delitem__ is implemented in SetitemMixin and dispatches to this method
+    # def __delitem__() is implemented in SetitemMixin and dispatches to this method
     @final
     def _delitem(self, key) -> None:
         """

pandas/core/series.py

@@ -1064,13 +1064,8 @@ def _get_value(self, label, takeable: bool = False):
         else:
             return self.iloc[loc]
 
+    # def __setitem__() is implemented in SetitemMixin and dispatches to this method
     def _setitem(self, key, value) -> None:
-        # if not PYPY:
-        #     if sys.getrefcount(self) <= 3:
-        #         warnings.warn(
-        #             _chained_assignment_msg, ChainedAssignmentError, stacklevel=2
-        #         )
-
         check_dict_or_set_indexers(key)
         key = com.apply_if_callable(key, self)