Implement configuration-based SOCKS proxy support #1428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
force-pushed
the
ckozak/socks
branch
from
49a45bf to
4671c3d
Compare
CRogers
reviewed
Nov 15, 2021
| log.debug("No SOCKS proxy found"); | ||
| } | ||
| return address; | ||
| } catch (RuntimeException e) { |
There was a problem hiding this comment.
This seems a little scary (as in might hide errors). Is this just to avoid breaking existing stuff in prod in case there is a problem with the socks detection?
There was a problem hiding this comment.
Ya, this should log at ERROR rather than DEBUG 👍
There was a problem hiding this comment.
You are correct, I added the catch to avoid adding risk to the production case.
|
👍 |
carterkozak
commented
Nov 15, 2021
...ogue-apache-hc5-client/src/main/java/com/palantir/dialogue/hc5/ApacheHttpClientChannels.java
Outdated
Show resolved
Hide resolved
…/hc5/ApacheHttpClientChannels.java
|
Released 3.30.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
palantir/conjure-java-runtime-api#699
palantir/conjure-java-runtime#2126
After this PR
==COMMIT_MSG==
Implement configuration-based SOCKS proxy support
==COMMIT_MSG==
Possible downsides?
More proxies, socks is particularly difficult to test